Skip to content

fix(UserPlugin): Don't search for displayname when restricted#61982

Merged
DerDreschner merged 1 commit into
masterfrom
fix/respect-displayname-restriction
Jul 14, 2026
Merged

fix(UserPlugin): Don't search for displayname when restricted#61982
DerDreschner merged 1 commit into
masterfrom
fix/respect-displayname-restriction

Conversation

@DerDreschner

@DerDreschner DerDreschner commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Summary

In December 2025, @juliusknorr implemented the feature to block full matches on the display name when using the share API (PR #57041). That feature was unintentionally being dropped on the rewrite of the UserPlugin by @susnux, leaving a non-functional toggle in the UI (PR #57511).

This issue is being fixed with this PR, re-adding the necessary checks on backend side as well as adding integration tests to prevent that from happening in the future.

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@DerDreschner DerDreschner requested a review from a team as a code owner July 10, 2026 21:28
@DerDreschner DerDreschner removed the request for review from a team July 10, 2026 21:28
@DerDreschner

Copy link
Copy Markdown
Contributor Author

/backport to stable33

@DerDreschner

Copy link
Copy Markdown
Contributor Author

/backport to stable34

@DerDreschner DerDreschner enabled auto-merge July 10, 2026 21:29
@DerDreschner DerDreschner changed the title fix(shareapi): Don't search for displayname when restricted fix(UserPlugin): Don't search for displayname when restricted Jul 10, 2026
@DerDreschner DerDreschner disabled auto-merge July 10, 2026 21:32
@DerDreschner DerDreschner enabled auto-merge July 10, 2026 21:32
@DerDreschner DerDreschner force-pushed the fix/respect-displayname-restriction branch from 561c2c7 to 29a7bf4 Compare July 12, 2026 00:59
@DerDreschner DerDreschner force-pushed the fix/respect-displayname-restriction branch from 29a7bf4 to 78047e0 Compare July 14, 2026 07:18
@DerDreschner DerDreschner added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 14, 2026
Assisted-by: ClaudeCode:claude-fable-5
Signed-off-by: David Dreschner <david.dreschner@nextcloud.com>
@DerDreschner DerDreschner force-pushed the fix/respect-displayname-restriction branch from 78047e0 to 1665420 Compare July 14, 2026 12:50
@DerDreschner DerDreschner merged commit be12340 into master Jul 14, 2026
207 checks passed
@DerDreschner DerDreschner deleted the fix/respect-displayname-restriction branch July 14, 2026 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish AI assisted feature: sharing regression

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants